linux-kernel - Re: [PATCH v2] arm: dts: bcm2711: Describe Ethernet LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171388152698.138785.3152955834733360539.robh@kernel.org>
Date: Tue, 23 Apr 2024 09:15:52 -0500
From: Rob Herring <robh@...nel.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: Viresh Kumar <viresh.kumar@...aro.org>, 
 Uwe Kleine-König <uwe@...ine-koenig.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 Heiko Stuebner <heiko@...ech.de>, 
 Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, 
 Stefan Wahren <wahrenst@....net>, devicetree@...r.kernel.org, 
 andrew@...n.ch, linux-rpi-kernel@...ts.infradead.org, 
 linux-arm-kernel@...ts.infradead.org, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
 Andre Przywara <andre.przywara@....com>, 
 Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, 
 linux-arm-kernel@...r.kernel.org, Tony Lindgren <tony@...mide.com>, 
 Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm: dts: bcm2711: Describe Ethernet LEDs


On Mon, 22 Apr 2024 16:07:31 -0700, Florian Fainelli wrote:
> Describe the Ethernet LEDs for the Raspberry Pi 4 model B board as well
> as the Raspberry Pi 4 CM board. The Raspberry Pi 400 board does not
> include RJ45 connector LEDs so the 'leds' node is deleted accordingly.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> ---
> Changes in v2:
> 
> - added "function = LED_FUNCTION_LAN"
> 
>  .../arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 20 +++++++++++++++++
>  .../arm/boot/dts/broadcom/bcm2711-rpi-400.dts |  1 +
>  .../boot/dts/broadcom/bcm2711-rpi-cm4-io.dts  | 22 +++++++++++++++++++
>  3 files changed, 43 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y broadcom/bcm2711-rpi-4-b.dtb broadcom/bcm2711-rpi-400.dtb broadcom/bcm2711-rpi-cm4-io.dtb' for 20240422230733.1284055-1-florian.fainelli@...adcom.com:

arch/arm/boot/dts/broadcom/bcm2711-rpi-cm4-io.dtb: ethernet-phy@0: leds: 'leds@1', 'leds@2' do not match any of the regexes: '^led@[a-f0-9]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
arch/arm/boot/dts/broadcom/bcm2711-rpi-400.dtb: ethernet-phy@1: leds: 'leds@0', 'leds@1' do not match any of the regexes: '^led@[a-f0-9]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dtb: ethernet-phy@1: leds: 'leds@0', 'leds@1' do not match any of the regexes: '^led@[a-f0-9]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#