linux-kernel - Re: [PATCH v1 2/2] Documentation: process: Recommend to put Cc: tags after cutter '---' line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZifeB_7DLa10BU__@smile.fi.intel.com>
Date: Tue, 23 Apr 2024 19:12:55 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: workflows@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v1 2/2] Documentation: process: Recommend to put Cc: tags
 after cutter '---' line

On Tue, Apr 23, 2024 at 09:07:09AM -0700, Greg KH wrote:
> On Tue, Apr 23, 2024 at 06:28:44PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 23, 2024 at 08:13:37AM -0700, Greg KH wrote:
> > > On Tue, Apr 23, 2024 at 04:19:38PM +0300, Andy Shevchenko wrote:
> > > > The recommendation is based on the following rationale:
> > > > 
> > > > - it makes the commit messages much cleaner and easy to read, especially
> > > >   on the screens of the mobile devices;
> > > 
> > > Reading commits on a mobile device is not what kernel development is
> > > optimized for, sorry.
> > 
> > The commit messages not always for the kernel development, some people may read
> > them in order to understand code better or many other reasons. I.o.w. it's not
> > the point.
> > 
> > > > - it reduces resources (memory, time, energy) to retrieve all these
> > > >   headers, which are barely needed by a mere user, as for automation
> > > >   they will be still available via mail archives, such as
> > > >   https://lore.kernel.org, assuming the Link: or Message-ID tag is
> > > >   provided.
> > > > 
> > > > Let's be environment friendly and save the planet!
> > > > 
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > ---
> > > >  Documentation/process/5.Posting.rst          | 4 ++++
> > > >  Documentation/process/submitting-patches.rst | 5 +++++
> > > >  2 files changed, 9 insertions(+)
> > > 
> > > This breaks my existing workflow, sorry.  I can't track cc: below the
> > > --- line because obviously, git cuts that off.  So I put them above
> > > where git send-email can see them,
> > 
> > git send-email _sees_ them very well there.
> 
> Sorry, yes, but git itself can't track them in the commit when I
> rebase/squash/redo/etc.  That's the point I was trying to make before my
> coffee kicked in...

It can in your _local_ repo if you have it as

  Signed-off-by:
  ---
  Cc:
  Cc:

in the commit message. It won't go to the final commit message if you sending
it out and apply via `git am`, or reapply with the latter locally instead of
cherry-picking.

-- 
With Best Regards,
Andy Shevchenko