linux-kernel - Re: [PATCH 1/2] dmaengine: qcom: Drop hidma DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 18:23:08 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: "Rob Herring (Arm)" <robh@...nel.org>, Sinan Kaya <okaya@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: qcom: Drop hidma DT support



On 4/23/24 18:14, Rob Herring (Arm) wrote:
> The DT support in hidma has been broken since commit 37fa4905d22a
> ("dmaengine: qcom_hidma: simplify DT resource parsing") in 2018. The
> issue is the of_address_to_resource() calls bail out on success rather
> than failure. This driver is for a defunct QCom server platform where
> DT use was limited to start with. As it seems no one has noticed the
> breakage, just remove the DT support altogether.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad