[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240423165350.GY42092@kernel.org>
Date: Tue, 23 Apr 2024 17:53:50 +0100
From: Simon Horman <horms@...nel.org>
To: Jesper Dangaard Brouer <hawk@...nel.org>
Cc: tj@...nel.org, hannes@...xchg.org, lizefan.x@...edance.com,
cgroups@...r.kernel.org, yosryahmed@...gle.com, longman@...hat.com,
netdev@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, shakeel.butt@...ux.dev,
kernel-team@...udflare.com,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
mhocko@...nel.org
Subject: Re: [PATCH v1 1/3] cgroup/rstat: add cgroup_rstat_lock helpers and
tracepoints
On Tue, Apr 16, 2024 at 07:51:26PM +0200, Jesper Dangaard Brouer wrote:
..
> /**
> * cgroup_rstat_flush_release - release cgroup_rstat_flush_hold()
> */
Hi Jesper,
as a follow-up could you add an entry for cgrp to the kernel doc above?
> -void cgroup_rstat_flush_release(void)
> +void cgroup_rstat_flush_release(struct cgroup *cgrp)
> __releases(&cgroup_rstat_lock)
> {
> - spin_unlock_irq(&cgroup_rstat_lock);
> + __cgroup_rstat_unlock(cgrp, -1);
> }
..
Powered by blists - more mailing lists