linux-kernel - Re: [PATCH v2 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIH0108 and PMD8028 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLZkU_74JK-BGOe83-redCi_TcV3dOOZs9DX3jThHfXrw@mail.gmail.com>
Date: Tue, 23 Apr 2024 12:02:34 -0500
From: Rob Herring <robh+dt@...nel.org>
To: Anjelique Melendez <quic_amelende@...cinc.com>
Cc: andersson@...nel.org, konrad.dybcio@...aro.org, linus.walleij@...aro.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	quic_subbaram@...cinc.com, quic_collinsd@...cinc.com, 
	quic_jprakash@...cinc.com
Subject: Re: [PATCH v2 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIH0108
 and PMD8028 support

On Tue, Mar 26, 2024 at 5:07 PM Anjelique Melendez
<quic_amelende@...cinc.com> wrote:
>
> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation
> to include compatible strings for PMIH0108 and PMD8028 PMICs.

You didn't test this with dtbs_check:

     47  gpio@...0: gpio-line-names: ['AP_SUSPEND', '', '', '', '',
'', '', '', '', '', '', ''] is too short
     10  gpio@...0: gpio-line-names: ['FLASH_STROBE_1', 'AP_SUSPEND',
'PM8008_1_RST_N', '', '', '', 'PMIC_EDP_BL_EN', 'PMIC_EDP_BL_PWM', '']
is too short

>
> Signed-off-by: Anjelique Melendez <quic_amelende@...cinc.com>
> ---
>  .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 2b17d244f051..a786357ed1af 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -57,10 +57,12 @@ properties:
>            - qcom,pma8084-gpio
>            - qcom,pmc8180-gpio
>            - qcom,pmc8180c-gpio
> +          - qcom,pmd8028-gpio
>            - qcom,pmi632-gpio
>            - qcom,pmi8950-gpio
>            - qcom,pmi8994-gpio
>            - qcom,pmi8998-gpio
> +          - qcom,pmih0108-gpio
>            - qcom,pmk8350-gpio
>            - qcom,pmk8550-gpio
>            - qcom,pmm8155au-gpio
> @@ -143,6 +145,7 @@ allOf:
>                - qcom,pm8005-gpio
>                - qcom,pm8450-gpio
>                - qcom,pm8916-gpio
> +              - qcom,pmd8028-gpio
>                - qcom,pmk8350-gpio
>                - qcom,pmr735a-gpio
>                - qcom,pmr735b-gpio
> @@ -304,6 +307,21 @@ allOf:
>            minItems: 1
>            maxItems: 7
>
> +  - if:
> +      properties:
> +        comptaible:

It took me a bit to find, but you've got a typo here. The result is
this "if" schema is always true unless you actually have an instance
with the typo too. Please send a fix.

> +          contains:
> +            enum:
> +              - qcom,pmih0108-gpio
> +    then:
> +      properties:
> +        gpio-line-names:
> +          minItems: 18
> +          maxItems: 18
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 9