linux-kernel - Re: [PATCH v2] gpio: Add Intel Granite Rapids-D vGPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zif-IHllDG6CmJmk@smile.fi.intel.com>
Date: Tue, 23 Apr 2024 21:29:52 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Aapo Vienamo <aapo.vienamo@...ux.intel.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	"Elliott, Robert (Servers)" <elliott@....com>,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v2] gpio: Add Intel Granite Rapids-D vGPIO driver

On Tue, Apr 23, 2024 at 09:13:14PM +0300, Aapo Vienamo wrote:
> This driver provides a basic GPIO driver for the Intel Granite Rapids-D
> virtual GPIOs. On SoCs with limited physical pins on the package, the
> physical pins controlled by this driver would be exposed on an external
> device such as a BMC or CPLD. The virtual GPIO registers are an
> interface to firmware, which communicates with the external device that
> implements the GPIO hardware functionality.

..

> +#include <linux/bitmap.h>
> +#include <linux/bits.h>

The latter is guaranteed to be included by the former. I can amend this when
applying.

..

I'll wait for others to review for a while. I want to send my PR to Bart at
the end of this week.

-- 
With Best Regards,
Andy Shevchenko