linux-kernel - RE: [PATCH] mei: bus: constify the struct mei_cl_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR11MB76051D97AC76E8FCDE464F2FE5112@PH7PR11MB7605.namprd11.prod.outlook.com>
Date: Tue, 23 Apr 2024 19:45:08 +0000
From: "Winkler, Tomas" <tomas.winkler@...el.com>
To: Kunwu Chan <chentao@...inos.cn>, "arnd@...db.de" <arnd@...db.de>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"kunwu.chan@...mail.com" <kunwu.chan@...mail.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mei: bus: constify the struct mei_cl_bus_type usage


> 
> Now that the driver core can properly handle constant struct bus_type,
> move the mei_cl_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
LGTM 
> ---
>  drivers/misc/mei/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index
> f9bcff197615..99393f610cdf 100644
> --- a/drivers/misc/mei/bus.c
> +++ b/drivers/misc/mei/bus.c
> @@ -1327,7 +1327,7 @@ static int mei_cl_device_uevent(const struct device
> *dev, struct kobj_uevent_env
>  	return 0;
>  }
> 
> -static struct bus_type mei_cl_bus_type = {
> +static const struct bus_type mei_cl_bus_type = {
>  	.name		= "mei",
>  	.dev_groups	= mei_cldev_groups,
>  	.match		= mei_cl_device_match,
> --
> 2.40.1