linux-kernel - Re: [PATCH v6 1/4] dt-bindings: media: add Maxim MAX96717 GMSL2 Serializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zigrei9JB9L2XUEO@valkosipuli.retiisi.eu>
Date: Tue, 23 Apr 2024 21:43:22 +0000
From: Sakari Ailus <sakari.ailus@....fi>
To: Julien Massot <julien.massot@...labora.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	kernel@...labora.com, linux-kernel@...r.kernel.org,
	mchehab@...nel.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Subject: Re: [PATCH v6 1/4] dt-bindings: media: add Maxim MAX96717 GMSL2
 Serializer

Hi Julien,

On Tue, Apr 23, 2024 at 03:36:39PM +0200, Julien Massot wrote:
> > > +            properties:
> > > +              data-lanes:
> > > +                minItems: 1
> > > +                maxItems: 4
> > > +
> > > +              lane-polarities:
> > > +                minItems: 1
> > > +                maxItems: 5
> > > +
> > > +              bus-type:
> > > +                enum:
> > > +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> > > +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
> > 
> > Now that you have C-PHY here, does the hardware support data line order
> > mapping? Just wondering. The bindings can be added without that and support
> > added later on---that's what the video-interfaces.yaml is currently
> > missing.
> > 
> > lane-polarities is only valid for D-PHY. What about the data-lanes, the
> > maximum is probably different for C-PHY?
> My mistake here; MAX96717 doesn't support C-PHY; I think I was confused by
> some of the schemas implying a deserializer with C-PHY support.
> I will drop the bus-type property in v7.

Ack, thanks!

-- 
Sakari Ailus