linux-kernel - Re: [PATCH] drm: Fix no_vblank field references in documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34a2b16c-58c5-4880-9b2f-fd5627085583@infradead.org>
Date: Tue, 23 Apr 2024 15:02:09 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH] drm: Fix no_vblank field references in documentation



On 4/16/24 2:02 PM, Randy Dunlap wrote:
> 
> 
> On 4/16/24 2:00 PM, Marijn Suijten wrote:
>> Hi Randy,
>>
>> [..]
>>
>>> Do you see differences in the generated html for these changes?
>>
>> I have not yet generated the HTML locally to test this patch, but will surely do
>> if that's a requirement.
>>
>>> "&struct somestruct" and "&somestruct" should both be OK AFAIK, although
>>> Documentation/doc-guide/kernel-doc.rst seems to say that using
>>> "&struct somestruct" is preferred.
>>
>> Keep in mind that this patch is about field/member references.  Quoting the
>> relevant paragraph under "Highlights and cross-references":
>>
>>   ``&struct_name->member`` or ``&struct_name.member``
>>     Structure or union member reference. The cross-reference will be to the struct
>>     or union definition, not the member directly.
>>
>> This lacks the struct tag entirely, and observation shows that links with them
>> don't highlight correctly (hence this patch) while member links without struct
>> tag are clickable and have an anchor link to their parent struct.
> 
> Alrigthy. Thank you.
> 

That means:
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html