linux-kernel - Re: [PATCH 1/1] mm: vmalloc: dump page owner info if page is already mapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 09:20:07 +0530
From: Hariom Panthi <hariom1.p@...sung.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: "urezki@...il.com" <urezki@...il.com>, "hch@...radead.org"
	<hch@...radead.org>, "lstoakes@...il.com" <lstoakes@...il.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Maninder Singh <maninder1.s@...sung.com>,
	Rohit Thapliyal <r.thapliyal@...sung.com>
Subject: Re: [PATCH 1/1] mm: vmalloc: dump page owner info if page is
 already mapped

Hi,

> > ...
> >
> > @@ -103,7 +105,13 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
> >          if (!pte)
> >                  return -ENOMEM;
> >          do {
> > -                BUG_ON(!pte_none(ptep_get(pte)));
> > +                if (!pte_none(ptep_get(pte))) {
> > +                        if (pfn_valid(pfn)) {
> > +                                page = pfn_to_page(pfn);
> > +                                dump_page_owner(page);
> > +                        }
> > +                        BUG();
> > +                }
> 
> Diving straight into dump_page_owner() seems inappropriate.  The
> higher-level dump_page() interface is more typically used.
> 
> Or, even more common, VM_BUG_ON_PAGE(), but that doesn't look to be a
> good fit here.

Ok I will send V2 with dump_page API.

Thanks,
Hariom