linux-kernel - Re: [PATCH] cpufreq: ti: Implement scope-based cleanup in ti_cpufreq_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 12:52:20 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Julia Lawall <julia.lawall@...ia.fr>
Cc: Shivani Gupta <shivani07g@...il.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	javier.carrasco.cruz@...il.com
Subject: Re: [PATCH] cpufreq: ti: Implement scope-based cleanup in
 ti_cpufreq_match_node()

On 23-04-24, 09:11, Julia Lawall wrote:
> 
> 
> On Tue, 23 Apr 2024, Shivani Gupta wrote:
> 
> > This patch modifies the ti_cpufreq_match_node() function to utilize the
> > __free() cleanup handler for automatically releasing the device
> > node when it goes out of scope.
> >
> > By moving the declaration to the initialization, the patch ensures that
> > the device node is properly managed throughout the function's scope,
> > thus eliminating the need for manual invocation of of_node_put().
> > This approach reduces the potential for memory leaks.
> 
> The code is fine.  The log message is a bit verbose.  Try to avoid
> referring to the patch.  It's obvious that you are talking about the
> patch.  Try to favor the imperative, so "Modify..." instead of "This patch
> modifies".

Fixed while applying.

-- 
viresh