linux-kernel - Re: [PATCH net-next v4] net: openvswitch: Check vport netdev name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e10353e-9e3e-4bf1-b825-7fe40f34748c@easystack.cn>
Date: Tue, 23 Apr 2024 10:34:32 +0800
From: Jun Gu <jun.gu@...ystack.cn>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dev@...nvswitch.org, echaudro@...hat.com, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4] net: openvswitch: Check vport netdev name

My mistake, I'm wondering that I need to submit a new patch or a v5 
version based on this patch?

在 4/23/24 08:38, Jakub Kicinski 写道:
> On Fri, 19 Apr 2024 14:14:25 +0800 Jun Gu wrote:
>>   	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
>> -	if (!vport->dev) {
>> +	/* Ensure that the device exists and that the provided
>> +	 * name is not one of its aliases.
>> +	 */
>> +	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
>>   		err = -ENODEV;
>>   		goto error_free_vport;
>>   	}
> 
> Sorry I applied this before I realised that it's buggy.
> dev_get_by_name() will give you a reference on the device.
> You must free it, so the error handling is different.
> Please follow up ASAP to fix that.
>