linux-kernel - Re: [PATCH] KVM: selftests: Add 'malloc' failure check in config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <981053d8-c67a-4958-9016-5f19c7884459@collabora.com>
Date: Tue, 23 Apr 2024 13:50:01 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Kunwu Chan <chentao@...inos.cn>, kunwu.chan@...mail.com,
 pbonzini@...hat.com, shuah@...nel.org
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kvm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: selftests: Add 'malloc' failure check in config_name

On 4/23/24 12:37 PM, Kunwu Chan wrote:
> There is a 'malloc' call in config_name function, which can
> be unsuccessful. This patch will add the malloc failure checking
> to avoid possible null dereference and give more information
> about test fail reasons.
> 
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
LGTM

Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/kvm/get-reg-list.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c
> index 91f05f78e824..22398696ffd6 100644
> --- a/tools/testing/selftests/kvm/get-reg-list.c
> +++ b/tools/testing/selftests/kvm/get-reg-list.c
> @@ -66,6 +66,7 @@ static const char *config_name(struct vcpu_reg_list *c)
>  		len += strlen(s->name) + 1;
>  
>  	c->name = malloc(len);
> +	TEST_ASSERT(c->name, "-ENOMEM when allocating config name");
>  
>  	len = 0;
>  	for_each_sublist(c, s) {

-- 
BR,
Muhammad Usama Anjum