linux-kernel - Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 12:54:55 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Markus Elfring <Markus.Elfring@....de>, linuxppc-dev@...ts.ozlabs.org, 
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, "Aneesh Kumar K.V"
 <aneesh.kumar@...nel.org>, Christophe Leroy <christophe.leroy@...roup.eu>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Haren Myneni <haren@...ux.ibm.com>,  Jakub Kicinski
 <kuba@...nel.org>, Michael Ellerman <mpe@...erman.id.au>, "Naveen N. Rao"
 <naveen.n.rao@...ux.ibm.com>, Nicholas Piggin <npiggin@...il.com>, Nick
 Child <nnac123@...ux.ibm.com>, Rick Lindsley <ricklind@...ux.ibm.com>,
 Thomas Falcon <tlfalcon@...ux.ibm.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

On Fri, 2024-04-19 at 16:08 +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 19 Apr 2024 15:46:17 +0200
> 
> Add a minus sign before the error code “EBUSY”
> so that a negative value will be used as in other cases.
> 
> This issue was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 5e9a93bdb518..737ae83a836a 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -3212,7 +3212,7 @@ static void __ibmvnic_reset(struct work_struct *work)
>  		    adapter->state == VNIC_REMOVED) {
>  			spin_unlock_irqrestore(&adapter->state_lock, flags);
>  			kfree(rwi);
> -			rc = EBUSY;
> +			rc = -EBUSY;
>  			break;
> 

AFAICS the error is always used as bool, so this will not change any
behavior in practice. I tend to think we should not merge this kind of
change outside some larger work in the same area, but I'd love a second
opinion from the driver owners.

Thanks,

Paolo
> 		}