linux-kernel - Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 19:22:47 +0800
From: Lance Yang <ioworker0@...il.com>
To: baolin.wang@...ux.alibaba.com
Cc: 21cnbao@...il.com, akpm@...ux-foundation.org, david@...hat.com, 
	hughd@...gle.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	ryan.roberts@....com, shy828301@...il.com, wangkefeng.wang@...wei.com, 
	willy@...radead.org, ying.huang@...el.com, ziy@...dia.com
Subject: Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters

On Tue, Apr 23, 2024 at 5:46 PM Lance Yang <ioworker0@...il.com> wrote:
>
> On 2024/4/23 09:17, Barry Song wrote:
> [...]
> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> >> index 26b6fa98d8ac..67b9c1acad31 100644
> >> --- a/include/linux/huge_mm.h
> >> +++ b/include/linux/huge_mm.h
> >> @@ -270,6 +270,8 @@ enum mthp_stat_item {
> >>          MTHP_STAT_ANON_SWPOUT,
> >>          MTHP_STAT_ANON_SWPOUT_FALLBACK,
> >>          MTHP_STAT_ANON_SWPIN_REFAULT,
> >> +       MTHP_STAT_SHMEM_ANON_ALLOC,
> >> +       MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK,

Seems like you forgot to add the FILE_FALLBACK_CHARGE counter
in this patch :)

IIUC, you've excluded the THP_FILE_FALLBACK_CHARGE counter
for PTE-mapped mTHP that size < PMD in patch3.

Thanks,
Lance