linux-kernel - Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 12:26:50 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Magnus Damm <magnus.damm@...il.com>, Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	linux-mmc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword

On Tue, Apr 23, 2024 at 10:59 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 23/04/2024 09:21, Lad, Prabhakar wrote:
> > Hi Krzysztof,
> >
> > Thank you for the review.
> >
> > On Tue, Apr 23, 2024 at 7:29 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >>
> >> On 22/04/2024 23:30, Prabhakar wrote:
> >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >>>
> >>> Drop 'items' keyword from compatible list which have single const value.
> >>>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >>> ---
> >>>  .../devicetree/bindings/mmc/renesas,sdhi.yaml  | 18 ++++++------------
> >>>  1 file changed, 6 insertions(+), 12 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> index 29f2400247eb..90c8b1b727a8 100644
> >>> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> @@ -12,16 +12,11 @@ maintainers:
> >>>  properties:
> >>>    compatible:
> >>>      oneOf:
> >>> -      - items:
> >>> -          - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r7s72100 # RZ/A1H
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r8a7740 # R-Mobile A1
> >>> +      - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> >>> +      - const: renesas,sdhi-r7s72100 # RZ/A1H
> >>> +      - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> >>> +      - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> >>> +      - const: renesas,sdhi-r8a7740 # R-Mobile A1
> >>
> >> That's just an enum.
> >>
> > Are you suggesting to group them into a single enum instead...?
>
> Yes. That's preferred form, easier to read, because it clearly documents
> that binding enumerates.
>
Agreed.

> But just in case you start changing all const to enums: don't. Comment
> is for this patch, since you already want to touch these things.
>
Indeed.

Cheers,
Prabhakar