linux-kernel - Re: [PATCH 5/7] um: Add an internal header shared among the user code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e850e5016348805e7e2f427ed98cb1eb539fc434.camel@sipsolutions.net>
Date: Tue, 23 Apr 2024 13:30:57 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Tiwei Bie <tiwei.btw@...group.com>, richard@....at, 
	anton.ivanov@...bridgegreys.com
Cc: linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] um: Add an internal header shared among the user
 code

On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote:
> 
>  $(USER_OBJS:.o=.%): \
> -	c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include $(srctree)/include/linux/kern_levels.h -include user.h $(CFLAGS_$(basetarget).o)
> +	c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include $(srctree)/include/linux/kern_levels.h \
> +		-include user.h -include $(srctree)/arch/um/os-Linux/internal.h $(CFLAGS_$(basetarget).o)
> 

Why not just include it explicitly? We do have the warnings?

johannes