linux-kernel - Re: [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 08:49:51 -0300
From: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing
 MODULE_DESCRIPTION()

On Mon, Apr 22, 2024 at 06:12:38PM +0300, Andy Shevchenko wrote:
> The modpost script is not happy
> 
>   WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
> 
> because there is a missing module description.
> 
> Add it to the module.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/platform/x86/classmate-laptop.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 87462e7c6219..fb208c68a7eb 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -13,8 +13,6 @@
>  #include <linux/input.h>
>  #include <linux/rfkill.h>
>  
> -MODULE_LICENSE("GPL");
> -
>  struct cmpc_accel {
>  	int sensitivity;
>  	int g_select;
> @@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = {
>  };
>  
>  MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
> +MODULE_DESCRIPTION("Support for Classmate PC ACPI devices");

How about "Support for Intel Classmate PC ACPI devices", like the
Kconfig devices?

Cascardo.

> +MODULE_LICENSE("GPL");
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
>