linux-kernel - Re: [PATCH 2/7] um: Fix the -Wmissing-prototypes warning for __switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2d61760-ca89-49d0-b366-89b3cd76438f@antgroup.com>
Date: Tue, 23 Apr 2024 20:11:15 +0800
From: "Tiwei Bie" <tiwei.btw@...group.com>
To: Johannes Berg <johannes@...solutions.net>, richard@....at,
 anton.ivanov@...bridgegreys.com
Cc: linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] um: Fix the -Wmissing-prototypes warning for
 __switch_mm

On 4/23/24 7:29 PM, Johannes Berg wrote:
> On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote:
>>
>> --- a/arch/um/include/shared/skas/mm_id.h
>> +++ b/arch/um/include/shared/skas/mm_id.h
>> @@ -15,4 +15,6 @@ struct mm_id {
>>  	int kill;
>>  };
>>  
>> +extern void __switch_mm(struct mm_id *mm_idp);
>>
> 
> Maybe drop the extern while at it?

Sure, will do. I also prefer to drop the extern.
Thanks for the review! :)

Regards,
Tiwei