| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Apr 2024 20:29:52 +0800 From: "Tiwei Bie" <tiwei.btw@...group.com> To: Johannes Berg <johannes@...solutions.net>, richard@....at, anton.ivanov@...bridgegreys.com Cc: linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 5/7] um: Add an internal header shared among the user code On 4/23/24 8:22 PM, Johannes Berg wrote: > On Tue, 2024-04-23 at 20:09 +0800, Tiwei Bie wrote: >> On 4/23/24 7:30 PM, Johannes Berg wrote: >>> On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote: >>>> >>>> $(USER_OBJS:.o=.%): \ >>>> - c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include $(srctree)/include/linux/kern_levels.h -include user.h $(CFLAGS_$(basetarget).o) >>>> + c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include $(srctree)/include/linux/kern_levels.h \ >>>> + -include user.h -include $(srctree)/arch/um/os-Linux/internal.h $(CFLAGS_$(basetarget).o) >>>> >>> >>> Why not just include it explicitly? >> >> I think it might be more convenient if we include it implicitly, >> especially since there are two levels of directories under os-Linux/. >> But I don't have a strong opinion on this. I'm also willing to >> include it explicitly. > > Yeah, ok, dunno. > >>> We do have the warnings? >> >> Yeah. Without this patch, I can get below warnings with `make ARCH=um defconfig && make ARCH=um`: >> > > Sure. I meant, we don't need to hide the include, if we need to add it > to some other file, we'll have the warnings as a reminder. :) > > I don't think anyone today would write the code as it is now ... Makes sense. Will include it explicitly. Thanks! Regards, Tiwei
Powered by blists - more mailing lists