linux-kernel - Re: [PATCH v1 1/1] fs/ntfs3: Fix compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zikbw9Z5p4XDiyMW@smile.fi.intel.com>
Date: Wed, 24 Apr 2024 17:48:35 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
	ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] fs/ntfs3: Fix compilation error

On Tue, Apr 23, 2024 at 11:56:34PM +0300, Andy Shevchenko wrote:
> Compilation with CONFIG_WERROR=y, which is default, is broken:
> 
>   fs/ntfs3/super.c:1247:26: error: variable 'attr' is uninitialized when used here [-Werror,-Wuninitialized]
> 
>   attr = ni_find_attr(ni, attr, NULL, ATTR_VOL_INFO, NULL, 0, NULL, NULL);
> 				^~~~
> Pass NULL instead.

Hmm... Something weird is going on. I'm looking now into the code and
have no clue why compiler is not okay with this code. The proposed patch
seems incorrect anyway.

-- 
With Best Regards,
Andy Shevchenko