linux-kernel - Re: [PATCH v2 1/1] ALSA: control: Use list_for_each_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZikcDLDnv1PX17wb@smile.fi.intel.com>
Date: Wed, 24 Apr 2024 17:49:48 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v2 1/1] ALSA: control: Use list_for_each_entry_safe()

On Wed, Apr 24, 2024 at 09:24:49AM +0200, Takashi Iwai wrote:
> On Tue, 23 Apr 2024 23:10:22 +0200,
> Andy Shevchenko wrote:
> > 
> > Instead of reiterating the list, use list_for_each_entry_safe()
> > that allows to continue without starting over.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Reviewed-by: Jaroslav Kysela <perex@...ex.cz>
> > ---
> > v2: added tag (Jaroslav)
> 
> We have a similar repeat in snd_ctl_led_reset().
> Wouldn't it be better to catch both?

Sure, v3 is on its way.

-- 
With Best Regards,
Andy Shevchenko