linux-kernel - Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACMJSeuBCkNyaD60qGVpAq91DqD_OA=tCVEY0t+JNK2vcWBc+Q@mail.gmail.com>
Date: Wed, 24 Apr 2024 16:52:28 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Marcel Holtmann <marcel@...tmann.org>, 
	Luiz Augusto von Dentz <luiz.dentz@...il.com>, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Wren Turkal <wt@...guintechs.org>, 
	Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL
 returned by gpiod_get_optional()

On Wed, 24 Apr 2024 at 16:46, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 24/04/2024 14:29, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
>
> >               qcadev->susclk = devm_clk_get_optional(&serdev->dev, NULL);
> >               if (IS_ERR(qcadev->susclk)) {
> > @@ -2355,10 +2360,13 @@ static int qca_serdev_probe(struct serdev_device *serdev)
> >               qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",
> >                                              GPIOD_OUT_LOW);
> >               if (IS_ERR(qcadev->bt_en)) {
> > -                     dev_warn(&serdev->dev, "failed to acquire enable gpio\n");
> > -                     power_ctrl_enabled = false;
> > +                     dev_err(&serdev->dev, "failed to acquire enable gpio\n");
> > +                     return PTR_ERR(qcadev->bt_en);
> >               }
> >
> > +             if (!qcadev->bt_en)
> > +                     power_ctrl_enabled = false;
>
> This looks duplicated - you already have such check earlier.
>

It's under a different switch case!

Bartosz