linux-kernel - Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 17:31:24 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: quic_zijuhu <quic_zijuhu@...cinc.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Marcel Holtmann <marcel@...tmann.org>, 
	Luiz Augusto von Dentz <luiz.dentz@...il.com>, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Wren Turkal <wt@...guintechs.org>
Subject: Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL
 returned by gpiod_get_optional()

On Wed, Apr 24, 2024 at 5:30 PM quic_zijuhu <quic_zijuhu@...cinc.com> wrote:
>
> On 4/24/2024 11:24 PM, quic_zijuhu wrote:
> > On 4/24/2024 10:52 PM, Bartosz Golaszewski wrote:
> >> On Wed, 24 Apr 2024 at 16:46, Krzysztof Kozlowski
> >> <krzysztof.kozlowski@...aro.org> wrote:
> >>>
> >>> On 24/04/2024 14:29, Bartosz Golaszewski wrote:
> >>>> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >>>>
> >>>
> >>>>               qcadev->susclk = devm_clk_get_optional(&serdev->dev, NULL);
> >>>>               if (IS_ERR(qcadev->susclk)) {
> >>>> @@ -2355,10 +2360,13 @@ static int qca_serdev_probe(struct serdev_device *serdev)
> >>>>               qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",
> >>>>                                              GPIOD_OUT_LOW);
> >>>>               if (IS_ERR(qcadev->bt_en)) {
> >>>> -                     dev_warn(&serdev->dev, "failed to acquire enable gpio\n");
> >>>> -                     power_ctrl_enabled = false;
> >>>> +                     dev_err(&serdev->dev, "failed to acquire enable gpio\n");
> >>>> +                     return PTR_ERR(qcadev->bt_en);
> > please think about for QCA2066. if it is returned from here.  BT will
> > not working at all.  if you don't return here. i will be working fine
> > for every BT functionality.
> sorry, correct a type error, it is QCA6390 not QCA2066.

Doesn't matter. If enable-gpios is not there, gpiod_get_optional()
will return NULL and we will not return.

Bart

> > NAK again by me.
> >
> >>>>               }
> >>>>
> >>>> +             if (!qcadev->bt_en)
> >>>> +                     power_ctrl_enabled = false;
> >>>
> >>> This looks duplicated - you already have such check earlier.
> >>>
> >>
> >> It's under a different switch case!
> >>
> >> Bartosz
> >
> >
>