linux-kernel - Re: [PATCH net-next] net: qede: flower: validate control flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <923135c6-1bd1-414d-b574-c201644d35ab@fiberby.net>
Date: Wed, 24 Apr 2024 16:43:14 +0000
From: Asbjørn Sloth Tønnesen <ast@...erby.net>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Ariel Elior <aelior@...vell.com>, Manish Chopra <manishc@...vell.com>
Subject: Re: [PATCH net-next] net: qede: flower: validate control flags

Hi Jiri,

On 4/24/24 2:52 PM, Jiri Pirko wrote:
> Wed, Apr 24, 2024 at 03:42:48PM CEST, ast@...erby.net wrote:
>> This driver currently doesn't support any flower control flags.
>>
>> Implement check for control flags, such as can be set through
>> `tc flower ... ip_flags frag`.
>>
>> Since qede_parse_flow_attr() are called by both qede_add_tc_flower_fltr()
>> and qede_flow_spec_to_rule(), as the latter doesn't having access to
>> extack, then flow_rule_*_control_flags() can't be used in this driver.
> 
> Why? You can pass null.

Ah, I see. I hadn't traced that option down through the defines,
I incorrectly assumed that NL_SET_ERR_MSG* didn't allow NULL.

Currently thinking about doing v2 in this style:

if (flow_rule_match_has_control_flags(rule, extack)) {
         if (!extack)
                 DP_NOTICE(edev, "Unsupported match on control.flags");
         return -EOPNOTSUPP;
}

pw-bot: changes-requested

-- 
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541