linux-kernel - Re: [RFC PATCH v4 00/20] RISC-V: ACPI: Add external interrupt controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871q6uir15.fsf@all.your.base.are.belong.to.us>
Date: Wed, 24 Apr 2024 19:55:50 +0200
From: Björn Töpel <bjorn@...nel.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Sunil V L
 <sunilvl@...tanamicro.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, linux-acpi@...r.kernel.org,
 linux-pci@...r.kernel.org, acpica-devel@...ts.linux.dev, Catalin Marinas
 <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
 <aou@...s.berkeley.edu>, "Rafael J . Wysocki" <rafael@...nel.org>, Len
 Brown <lenb@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Anup Patel
 <anup@...infault.org>, Thomas Gleixner <tglx@...utronix.de>, Samuel
 Holland <samuel.holland@...ive.com>, Robert Moore
 <robert.moore@...el.com>, Haibo1 Xu <haibo1.xu@...el.com>, Conor Dooley
 <conor.dooley@...rochip.com>, Andrew Jones <ajones@...tanamicro.com>,
 Atish Kumar Patra <atishp@...osinc.com>, Andrei Warkentin
 <andrei.warkentin@...el.com>, Marc Zyngier <maz@...nel.org>
Subject: Re: [RFC PATCH v4 00/20] RISC-V: ACPI: Add external interrupt
 controller support

"Rafael J. Wysocki" <rafael@...nel.org> writes:

> On Mon, Apr 15, 2024 at 7:01 PM Sunil V L <sunilvl@...tanamicro.com> wrote:
>>
>> This series adds support for the below ECR approved by ASWG.
>> 1) MADT - https://drive.google.com/file/d/1oMGPyOD58JaPgMl1pKasT-VKsIKia7zR/view?usp=sharing
>>
>> The series primarily enables irqchip drivers for RISC-V ACPI based
>> platforms.
>>
>> The series can be broadly categorized like below.
>>
>> 1) PCI ACPI related functions are migrated from arm64 to common file so
>> that we don't need to duplicate them for RISC-V.
>>
>> 2) Added support for re-ordering the probe of interrupt controllers when
>> IRQCHIP_ACPI_DECLARE is used.
>>
>> 3) To ensure probe order between interrupt controllers and devices,
>> implicit dependency is created similar to when _DEP is present.
>>
>> 4) When PNP devices like Generic 16550A UART, have the dependency on the
>> interrupt controller, they will not be added to PNP data structures. So,
>> added second phase of pnpacpi_init to handle this.
>>
>> 5) ACPI support added in RISC-V interrupt controller drivers.
>>
>> This series is still kept as RFC to seek feedback on above design
>> changes. Looking forward for the feedback!
>
> I've looked at the patches and I don't see anything deeply concerning
> in them from the ACPI core code perspective.
>
> The changes look reasonably straightforward to me.

Sunil, given Rafael's input, it sounds like it's time for a patch
proper. This is really the missing piece to make ACPI usable on RISC-V!

Thanks for the nice work!
Björn

FWIW,
Tested-by: Björn Töpel <bjorn@...osinc.com>