linux-kernel - Re: [PATCH] dt-bindings: mfd: allwinner,sun6i-a31-prcm: Use hyphens in node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2320577.ElGaqSPkdT@jernej-laptop>
Date: Wed, 24 Apr 2024 20:58:13 +0200
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Chen-Yu Tsai <wens@...e.org>, Samuel Holland <samuel@...lland.org>,
 Maxime Ripard <mripard@...nel.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject:
 Re: [PATCH] dt-bindings: mfd: allwinner,sun6i-a31-prcm: Use hyphens in node
 names

Dne sreda, 24. april 2024 ob 06:55:21 GMT +2 je Krzysztof Kozlowski napisal(a):
> Underscores should not be used in node names (dtc with W=2 warns about
> them), so replace them with hyphens.  This should have no impact on
> known users: Linux MFD driver does not care about children node names.
> DTS was already adjusted in commit 0f47ef3ff1bd ("arm: dts: allwinner: drop
> underscore in node names"), so without this change, we observe
> dtbs_check warnings:
> 
>   sun6i-a31s-colorfly-e708-q1.dtb: prcm@...1400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk', 'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes: '^.*_(clk|rst)$', 'pinctrl-[0-9]+'
> 
> Reported-by: Rob Herring <robh@...nel.org>
> Closes: https://lore.kernel.org/all/CAL_JsqJfT-jui5P56CO4Fr37kr5iNN8dpxt8ecKeFmdVGnRYbA@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  .../bindings/mfd/allwinner,sun6i-a31-prcm.yaml     | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml
> index 8789e3639ff7..ca0e9f1f2354 100644
> --- a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml
> +++ b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml
> @@ -20,7 +20,7 @@ properties:
>      maxItems: 1
>  
>  patternProperties:
> -  "^.*_(clk|rst)$":
> +  "^.*-(clk|rst)$":
>      type: object
>      unevaluatedProperties: false
>  
> @@ -171,7 +171,7 @@ examples:
>          compatible = "allwinner,sun6i-a31-prcm";
>          reg = <0x01f01400 0x200>;
>  
> -        ar100: ar100_clk {
> +        ar100: ar100-clk {
>              compatible = "allwinner,sun6i-a31-ar100-clk";
>              #clock-cells = <0>;
>              clocks = <&rtc 0>, <&osc24M>,
> @@ -180,7 +180,7 @@ examples:
>              clock-output-names = "ar100";
>          };
>  
> -        ahb0: ahb0_clk {
> +        ahb0: ahb0-clk {
>              compatible = "fixed-factor-clock";
>              #clock-cells = <0>;
>              clock-div = <1>;
> @@ -189,14 +189,14 @@ examples:
>              clock-output-names = "ahb0";
>          };
>  
> -        apb0: apb0_clk {
> +        apb0: apb0-clk {
>              compatible = "allwinner,sun6i-a31-apb0-clk";
>              #clock-cells = <0>;
>              clocks = <&ahb0>;
>              clock-output-names = "apb0";
>          };
>  
> -        apb0_gates: apb0_gates_clk {
> +        apb0_gates: apb0-gates-clk {
>              compatible = "allwinner,sun6i-a31-apb0-gates-clk";
>              #clock-cells = <1>;
>              clocks = <&apb0>;
> @@ -206,14 +206,14 @@ examples:
>                                   "apb0_i2c";
>          };
>  
> -        ir_clk: ir_clk {
> +        ir_clk: ir-clk {
>              #clock-cells = <0>;
>              compatible = "allwinner,sun4i-a10-mod0-clk";
>              clocks = <&rtc 0>, <&osc24M>;
>              clock-output-names = "ir";
>          };
>  
> -        apb0_rst: apb0_rst {
> +        apb0_rst: apb0-rst {
>              compatible = "allwinner,sun6i-a31-clock-reset";
>              #reset-cells = <1>;
>          };
>