linux-kernel - Re: [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 15:11:05 -0500
From: Rob Herring <robh@...nel.org>
To: Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
Cc: Mark Brown <broonie@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Michal Simek <michal.simek@....com>,
	Ley Foon Tan <leyfoon.tan@...rfivetech.com>,
	linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Eng Lee Teh <englee.teh@...rfivetech.com>
Subject: Re: [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset
 control

On Wed, Apr 24, 2024 at 01:13:17PM +0800, Ji Sheng Teoh wrote:
> Document the optional reset control to SPI.
> 
> Signed-off-by: Eng Lee Teh <englee.teh@...rfivetech.com>
> Signed-off-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>

3 people developed 4 lines of code? Generally the first S-o-b should be 
the author (.i.e. a From line).

> ---
>  Documentation/devicetree/bindings/spi/spi-cadence.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index d4b61b0e8301..2358489be4bc 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -55,6 +55,11 @@ properties:
>    label:
>      description: Descriptive name of the SPI controller.
>  
> +  resets:
> +    description: |
> +      Optional entry to specify the reset controller to the SPI

Drop the description.

> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.43.2
>