linux-kernel - Re: [PATCH] ubsan: Remove 1-element array usage in debug reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfd32c82-8909-48f7-ba5c-22c08b5eb53a@embeddedor.com>
Date: Wed, 24 Apr 2024 15:14:42 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Kees Cook <keescook@...omium.org>,
 "Gustavo A . R . Silva" <gustavoars@...nel.org>
Cc: Marco Elver <elver@...gle.com>, Andrey Konovalov <andreyknvl@...il.com>,
 Andrey Ryabinin <ryabinin.a.a@...il.com>, kasan-dev@...glegroups.com,
 linux-hardening@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubsan: Remove 1-element array usage in debug reporting

On 24/04/24 10:27, Kees Cook wrote:
> The "type_name" character array was still marked as a 1-element array.
> While we don't validate strings used in format arguments yet, let's fix
> this before it causes trouble some future day.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks!
--
Gustavo

> ---
> Cc: Gustavo A. R. Silva <gustavoars@...nel.org>
> Cc: Marco Elver <elver@...gle.com>
> Cc: Andrey Konovalov <andreyknvl@...il.com>
> Cc: Andrey Ryabinin <ryabinin.a.a@...il.com>
> Cc: kasan-dev@...glegroups.com
> Cc: linux-hardening@...r.kernel.org
> ---
>   lib/ubsan.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ubsan.h b/lib/ubsan.h
> index 0abbbac8700d..50ef50811b7c 100644
> --- a/lib/ubsan.h
> +++ b/lib/ubsan.h
> @@ -43,7 +43,7 @@ enum {
>   struct type_descriptor {
>   	u16 type_kind;
>   	u16 type_info;
> -	char type_name[1];
> +	char type_name[];
>   };
>   
>   struct source_location {