linux-kernel - Re: [PATCHv2 4/4] x86/tdx: Enable ENUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f4c664e-665b-495c-b6d0-04899a3c216b@intel.com>
Date: Wed, 24 Apr 2024 15:20:54 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
 tglx@...utronix.de, mingo@...hat.com, bp@...en8.de
Cc: sathyanarayanan.kuppuswamy@...ux.intel.com, hpa@...or.com,
 seanjc@...gle.com, elena.reshetova@...el.com, rick.p.edgecombe@...el.com,
 x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 4/4] x86/tdx: Enable ENUM_TOPOLOGY

On 3/25/24 03:46, Kirill A. Shutemov wrote:
> +	if ((features & TDX_FEATURES0_ENUM_TOPOLOGY) &&
> +	    tdg_vm_rd(TDCS_TOPOLOGY_ENUM_CONFIGURED)) {
> +		if (!tdcs_ctls_set(TD_CTLS_ENUM_TOPOLOGY))
> +			pr_warn("Failed to enable ENUM_TOPOLOGY\n");
> +	}

This is looking pretty familiar at this point.

I'd almost rather just have it do a plain old:

	tdcs_ctls_set(TD_CTLS_ENUM_TOPOLOGY);

.. and leave it at that.

*If* there is a generic return code for "invalid" as opposed to a
not-supported tdcs_ctls_set(), then it's arguable that you can spit out
a message for an unexpected "invalid" error.

But seriously, why all the complexity over and over?  What does this buy?