linux-kernel - Re: [PATCH-cgroup] cgroup/cpuset: Fix incorrect top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zih9OG8Azp5vrg9f@slm.duckdns.org>
Date: Tue, 23 Apr 2024 17:32:08 -1000
From: Tejun Heo <tj@...nel.org>
To: Waiman Long <longman@...hat.com>
Cc: Zefan Li <lizefan.x@...edance.com>,
	Johannes Weiner <hannes@...xchg.org>, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, Xiu Jianfeng <xiujianfeng@...wei.com>
Subject: Re: [PATCH-cgroup] cgroup/cpuset: Fix incorrect top_cpuset flags

On Tue, Apr 23, 2024 at 09:00:20PM -0400, Waiman Long wrote:
> Commit 8996f93fc388 ("cgroup/cpuset: Statically initialize more
> members of top_cpuset") uses an incorrect "<" relational operator for
> the CS_SCHED_LOAD_BALANCE bit when initializing the top_cpuset. This
> results in load_balancing turned off by default in the top cpuset which
> is bad for performance.
> 
> Fix this by using the BIT() helper macro to set the desired top_cpuset
> flags and avoid similar mistake from being made in the future.
> 
> Fixes: 8996f93fc388 ("cgroup/cpuset: Statically initialize more members of top_cpuset")
> Signed-off-by: Waiman Long <longman@...hat.com>

Applied to cgroup/for-6.10.

Thanks.

-- 
tejun