linux-kernel - Re: [PATCH 4/4] arm: dts: allwinner: drop underscore in node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 06:41:56 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, Corentin Labbe <clabbe@...libre.com>,
 Maxime Ripard <mripard@...nel.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] arm: dts: allwinner: drop underscore in node names

On 23/04/2024 23:23, Rob Herring wrote:
> On Sun, Mar 17, 2024 at 1:41 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> Underscores should not be used in node names (dtc with W=2 warns about
>> them), so replace them with hyphens.  Use also generic name for pwrseq
>> node, because generic naming is favored by Devicetree spec.  All the
>> clocks affected by this change use clock-output-names, so resulting
>> clock name should not change.  Functional impact checked with comparing
>> before/after DTBs with dtx_diff and fdtdump.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> This adds warnings:
> 
> 13  prcm@...1400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk',
> 'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes:
> '^.*_(clk|rst)$', 'pinctrl-[0-9]+'
> 
> Since we documented it with underscores, I'd say just leave these at
> least until if/when we define some standard names. I'd prefer we spend
> time reducing warnings from the common schema. I'm looking at
> root-node.yaml. simple-bus.yaml generates a lot too.

Uh, this was already picked up. I will send patch for schema, thanks for
the report.

Best regards,
Krzysztof