linux-kernel - Re: [PATCH v9 06/13] of: property: fw_devlink: Add support for "access-controller"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx8HdnspNfDEJP+cqShJPsDryzGkOVq6B99cFQzkZi3dMg@mail.gmail.com>
Date: Tue, 23 Apr 2024 22:57:40 -0700
From: Saravana Kannan <saravanak@...gle.com>
To: Gatien Chevallier <gatien.chevallier@...s.st.com>
Cc: Oleksii_Moisieiev@...m.com, gregkh@...uxfoundation.org, 
	herbert@...dor.apana.org.au, davem@...emloft.net, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	alexandre.torgue@...s.st.com, vkoul@...nel.org, jic23@...nel.org, 
	olivier.moysan@...s.st.com, arnaud.pouliquen@...s.st.com, mchehab@...nel.org, 
	fabrice.gasnier@...s.st.com, andi.shyti@...nel.org, ulf.hansson@...aro.org, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	hugues.fruchet@...s.st.com, lee@...nel.org, will@...nel.org, 
	catalin.marinas@....com, arnd@...nel.org, richardcochran@...il.com, 
	Frank Rowand <frowand.list@...il.com>, peng.fan@....nxp.com, lars@...afoo.de, 
	rcsekar@...sung.com, wg@...ndegger.com, mkl@...gutronix.de, 
	linux-crypto@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	dmaengine@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-iio@...r.kernel.org, alsa-devel@...a-project.org, 
	linux-media@...r.kernel.org, linux-mmc@...r.kernel.org, 
	netdev@...r.kernel.org, linux-phy@...ts.infradead.org, 
	linux-serial@...r.kernel.org, linux-spi@...r.kernel.org, 
	linux-usb@...r.kernel.org, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v9 06/13] of: property: fw_devlink: Add support for "access-controller"

On Fri, Jan 5, 2024 at 5:03 AM Gatien Chevallier
<gatien.chevallier@...s.st.com> wrote:
>
> Allows tracking dependencies between devices and their access
> controller.
>
> Signed-off-by: Gatien Chevallier <gatien.chevallier@...s.st.com>
> Acked-by: Rob Herring <robh@...nel.org>

Please cc me on fw_devlink patches. Also, this patch is breaking the
norm below. Please send a fix up patch.

> ---
> Changes in V9:
>         - Added Rob's review tag
>
> Changes in V6:
>         - Renamed access-controller to access-controllers
>
> Changes in V5:
>         - Rename feature-domain* to access-control*
>
> Patch not present in V1
>
>  drivers/of/property.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index afdaefbd03f6..7f737eac91b2 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1268,6 +1268,7 @@ DEFINE_SIMPLE_PROP(leds, "leds", NULL)
>  DEFINE_SIMPLE_PROP(backlight, "backlight", NULL)
>  DEFINE_SIMPLE_PROP(panel, "panel", NULL)
>  DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells")
> +DEFINE_SIMPLE_PROP(access_controllers, "access-controllers", "#access-controller-cells")
>  DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
>  DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
>
> @@ -1363,6 +1364,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
>         { .parse_prop = parse_regulators, },
>         { .parse_prop = parse_gpio, },
>         { .parse_prop = parse_gpios, },
> +       { .parse_prop = parse_access_controllers, },

All the simple properties are listed before the suffix ones as the
suffix checks are more expensive. So, you should have inserted this
right before the suffix properties. Also, there's a merge conflict in
linux-next. So make sure you take that into account when sending the
fix up and picking the order.

-Saravana

>         {}
>  };

>
> --
> 2.35.3
>