[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<DU0PR04MB941723CDA3A07046823A8A5788102@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Wed, 24 Apr 2024 07:05:59 +0000
From: Peng Fan <peng.fan@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Lee Jones <lee@...nel.org>, Daniel
Thompson <daniel.thompson@...aro.org>, Jingoo Han <jingoohan1@...il.com>,
Helge Deller <deller@....de>, Bruno Prémont
<bonbons@...ux-vserver.org>, Jiri Kosina <jikos@...nel.org>, Benjamin
Tissoires <bentiss@...nel.org>, Alexander Shiyan <shc_work@...l.ru>, Sascha
Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
<kernel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>, Fabio Estevam
<festevam@...il.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
<imx@...ts.linux.dev>, "linux-omap@...r.kernel.org"
<linux-omap@...r.kernel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Subject: RE: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops
> Subject: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops
>
> 'struct lcd_ops' is not modified by core backlight code, so it can be made
> const for increased code safety.
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
Reviewed-by: Peng Fan <peng.fan@....com>
> ---
>
> Depends on the first patch in the series.
> ---
> drivers/video/fbdev/imxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index
> a4dbc72f93c3..4ebfe9b9df60 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -857,7 +857,7 @@ static int imxfb_lcd_set_power(struct lcd_device
> *lcddev, int power)
> return 0;
> }
>
> -static struct lcd_ops imxfb_lcd_ops = {
> +static const struct lcd_ops imxfb_lcd_ops = {
> .check_fb = imxfb_lcd_check_fb,
> .get_contrast = imxfb_lcd_get_contrast,
> .set_contrast = imxfb_lcd_set_contrast,
>
> --
> 2.43.0
>
Powered by blists - more mailing lists