linux-kernel - Re: [PATCH net] octeontx2-af: fix the double free in rvu_npc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ed5b3e0-933a-4a6c-a07c-3cdc8a9cc680@web.de>
Date: Wed, 24 Apr 2024 09:56:11 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Su Hui <suhui@...china.com>, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, Bill Wendling <morbo@...gle.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Geethasowjanya Akula <gakula@...vell.com>,
 Hariprasad Kelam <hkelam@...vell.com>, Jakub Kicinski <kuba@...nel.org>,
 Jerin Jacob <jerinj@...vell.com>, Justin Stitt <justinstitt@...gle.com>,
 Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>,
 Linu Cherian <lcherian@...vell.com>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>
Cc: LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev,
 Suman Ghosh <sumang@...vell.com>
Subject: Re: [PATCH net] octeontx2-af: fix the double free in
 rvu_npc_freemem()

…
> npc_mcam_rsrcs_deinit() has released 'mcam->counters.bmap'. Deleted this
> redundant kfree() to fix this double free problem.
…

Can a wording variant (like the following) be a bit nicer?

   The object “mcam->counters.bmap” was released during the execution of
   the function “npc_mcam_rsrcs_deinit”.
   Delete a subsequent kfree() call to fix this double free problem.

Regards,
Markus