linux-kernel - RE: Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS4PR04MB938629FE2E40DA32B8A95E2AE1102@AS4PR04MB9386.eurprd04.prod.outlook.com>
Date: Wed, 24 Apr 2024 09:04:36 +0000
From: Joy Zou <joy.zou@....com>
To: Marco Felsch <m.felsch@...gutronix.de>
CC: Frank Li <frank.li@....com>, Jacky Bai <ping.bai@....com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, dl-linux-imx <linux-imx@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE:  Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131
 support


> -----Original Message-----
> From: Marco Felsch <m.felsch@...gutronix.de>
> Sent: 2024年4月24日 17:00
> To: Joy Zou <joy.zou@....com>
> Cc: Frank Li <frank.li@....com>; Jacky Bai <ping.bai@....com>;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> conor+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> <linux-imx@....com>; devicetree@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc
> PCF2131 support
> 
> On 24-04-24, Joy Zou wrote:
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > index 07e85a30a25f..bc3c9271d747 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > @@ -281,6 +281,23 @@ ldo5: LDO5 {
> > > >       };
> > > >  };
> > > >
> > > > +&lpi2c3 {
> > > > +     #address-cells = <1>;
> > > > +     #size-cells = <0>;
> > >
> > > while reading your patch I also noticed that you had to specify
> > > these cells here. It is very common to specify it within the base
> > > dtsi file imx93.dtsi. Can you please provde an extra patch which
> > > adds this to the base dtsi followed by this patch, which of course do need
> to specify it again.
> > >
> > > Thanks you,
> > >   Marco
> > >
> > Thanks for your comments!
> > Have checked the base dtsi file imx93.dtsi. The these cells already existed.
> 
> You're right, not sure why I didn't saw it in the first place.
> 
> > The current cells is same with the lpi2c3 node in imx93.dtsi. So
> > should remove these cells in order to keep terse?
> 
> Yes please remove it.
> 
> Regards,
>   Marco

Thanks for your comments!
Will change it in next version.
BR
Joy Zou