linux-kernel - Re: [PATCH v3 4/4] media: mediatek: imgsys: Support image processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 12:04:54 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Olivia Wen <olivia.wen@...iatek.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>, Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, Tinghan Shen <tinghan.shen@...iatek.com>,
 linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com,
 jason-ch.chen@...iatek.com, yaya.chang@...iatek.com, teddy.chen@...iatek.com
Subject: Re: [PATCH v3 4/4] media: mediatek: imgsys: Support image processing

Il 24/04/24 12:02, AngeloGioacchino Del Regno ha scritto:
> Il 24/04/24 05:03, Olivia Wen ha scritto:
>> Integrate the imgsys core architecture driver for image processing on
>> the MT8188 platform.
>>
>> Signed-off-by: Olivia Wen <olivia.wen@...iatek.com>
> 
> This should be reordered before introducing the 8188 scp core 1 support commit,
> but let's check with Mathieu before sending a v4.
> 
> With that reordered,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Wait, no. Sorry. I just noticed that the commit message is totally wrong.

This is not a media commit, but remoteproc, and you're not adding support for
image processing with this commit - not in media at least.
Also, you're not adding any imgsys core architecture driver.

Please fix both commit description and title.

Regards,
Angelo

> 
>> ---
>>   include/linux/remoteproc/mtk_scp.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/remoteproc/mtk_scp.h b/include/linux/remoteproc/mtk_scp.h
>> index 7c2b7cc9..344ff41 100644
>> --- a/include/linux/remoteproc/mtk_scp.h
>> +++ b/include/linux/remoteproc/mtk_scp.h
>> @@ -43,6 +43,7 @@ enum scp_ipi_id {
>>       SCP_IPI_CROS_HOST_CMD,
>>       SCP_IPI_VDEC_LAT,
>>       SCP_IPI_VDEC_CORE,
>> +    SCP_IPI_IMGSYS_CMD,
>>       SCP_IPI_NS_SERVICE = 0xFF,
>>       SCP_IPI_MAX = 0x100,
>>   };
>