linux-kernel - [PATCH v1] selftests/mm: soft-dirty should fail if a testcase fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20240424105301.3157695-1-ryan.roberts@arm.com>
Date: Wed, 24 Apr 2024 11:53:01 +0100
From: Ryan Roberts <ryan.roberts@....com>
To: Andrew Morton <akpm@...ux-foundation.org>,
	Shuah Khan <shuah@...nel.org>
Cc: Ryan Roberts <ryan.roberts@....com>,
	linux-mm@...ck.org,
	linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Muhammad Usama Anjum <usama.anjum@...labora.com>,
	David Hildenbrand <david@...hat.com>
Subject: [PATCH v1] selftests/mm: soft-dirty should fail if a testcase fails

Previously soft-dirty was unconditionally exiting with success, even if
one of it's testcases failed. Let's fix that so that failure can be
reported to automated systems properly.

Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
Reviewed-by: David Hildenbrand <david@...hat.com>
Signed-off-by: Ryan Roberts <ryan.roberts@....com>
---

Applies on top of v6.9-rc3.

I previously sent this out as part of a larger series [1]. Feedback was to
repost standalone.

[1] https://lore.kernel.org/all/20240419074344.2643212-1-ryan.roberts@arm.com/

Thanks,
Ryan


 tools/testing/selftests/mm/soft-dirty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c
index 7dbfa53d93a0..bdfa5d085f00 100644
--- a/tools/testing/selftests/mm/soft-dirty.c
+++ b/tools/testing/selftests/mm/soft-dirty.c
@@ -209,5 +209,5 @@ int main(int argc, char **argv)

 	close(pagemap_fd);

-	return ksft_exit_pass();
+	ksft_finished();
 }
--
2.25.1