| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3f834858-628b-4f21-bd85-1833cd8ccc98@xs4all.nl> Date: Wed, 24 Apr 2024 13:11:51 +0200 From: Hans Verkuil <hverkuil@...all.nl> To: Ricardo Ribalda <ribalda@...omium.org>, Martin Tuma <martin.tuma@...iteqautomotive.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Hugues Fruchet <hugues.fruchet@...s.st.com>, Alain Volmat <alain.volmat@...s.st.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Paul Kocialkowski <paul.kocialkowski@...tlin.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Sowjanya Komatineni <skomatineni@...dia.com>, Luca Ceresoli <luca.ceresoli@...tlin.com>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Sergey Kozlov <serjk@...up.ru>, Abylay Ospan <aospan@...up.ru>, Ezequiel Garcia <ezequiel@...guardiasur.com.ar>, Dmitry Osipenko <digetx@...il.com>, Benjamin Mugnier <benjamin.mugnier@...s.st.com>, Sylvain Petinot <sylvain.petinot@...s.st.com>, Stanimir Varbanov <stanimir.k.varbanov@...il.com>, Vikash Garodia <quic_vgarodia@...cinc.com>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org> Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev, linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org, linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org, Sergey Senozhatsky <senozhatsky@...omium.org>, Kieran Bingham <kieran.bingham@...asonboard.com>, Dan Carpenter <dan.carpenter@...aro.org> Subject: Re: [PATCH v2 00/26] media: Fix coccinelle warning/errors On 19/04/2024 11:47, Ricardo Ribalda wrote: > After this set is applied, these are the only warnings left: > drivers/media/pci/ivtv/ivtv-fileops.c:223:4-10: preceding lock on line 267 > drivers/media/pci/ivtv/ivtv-fileops.c:230:3-9: preceding lock on line 267 > drivers/media/pci/ivtv/ivtv-fileops.c:236:4-10: preceding lock on line 267 > drivers/media/pci/ivtv/ivtv-fileops.c:245:3-9: preceding lock on line 267 > drivers/media/pci/ivtv/ivtv-fileops.c:251:3-9: preceding lock on line 267 > drivers/media/pci/ivtv/ivtv-fileops.c:257:3-9: preceding lock on line 267 > drivers/media/pci/ivtv/ivtv-fileops.c:272:3-9: preceding lock on line 267 > drivers/media/pci/ivtv/ivtv-fileops.c:598:4-10: preceding lock on line 627 > drivers/media/pci/ivtv/ivtv-fileops.c:598:4-10: preceding lock on line 689 > drivers/media/pci/ivtv/ivtv-fileops.c:606:3-9: preceding lock on line 627 > drivers/media/pci/ivtv/ivtv-fileops.c:606:3-9: preceding lock on line 689 > drivers/media/pci/ivtv/ivtv-fileops.c:648:3-9: preceding lock on line 627 > drivers/media/pci/ivtv/ivtv-fileops.c:648:3-9: preceding lock on line 689 > drivers/media/pci/ivtv/ivtv-fileops.c:692:4-10: preceding lock on line 689 > drivers/media/dvb-core/dvb_frontend.c:2897:1-7: preceding lock on line 2776 > drivers/media/dvb-core/dvb_frontend.c:2897:1-7: preceding lock on line 2786 > drivers/media/dvb-core/dvb_frontend.c:2897:1-7: preceding lock on line 2809 > drivers/media/dvb-frontends/stv090x.c:799:1-7: preceding lock on line 768 > drivers/media/usb/go7007/go7007-i2c.c:125:1-7: preceding lock on line 61 > drivers/media/rc/imon.c:1167:1-7: preceding lock on line 1153 > drivers/media/pci/cx18/cx18-scb.h:261:22-29: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:77:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:154:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:171:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:201:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:220:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_cmds.h:230:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1008:43-60: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1014:36-46: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1267:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/common/siano/smscoreapi.h:619:5-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/common/siano/smscoreapi.h:669:6-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/common/siano/smscoreapi.h:1049:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/common/siano/smscoreapi.h:1055:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/dvb-frontends/mxl5xx_defs.h:171:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/dvb-frontends/mxl5xx_defs.h:182:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/allegro-dvt/nal-hevc.h:102:14-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/media/platform/xilinx/xilinx-dma.h:100:19-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > drivers/staging/media/atomisp/pci/atomisp_tpg.h:30:18-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > > CI tested: > https://gitlab.freedesktop.org/linux-media/media-staging/-/commit/055b5211c68e721c3a7090be5373cf44859da1a7/pipelines?ref=ribalda%2Ftest-cocci Other than what others already reported, plus my own two comments, this series looks good. So likely I can pick up v3 once it is posted. Regards, Hans > > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org> > --- > Changes in v2: > - Remove all the min() retval, and send a patch for cocci: https://lore.kernel.org/lkml/20240415-minimax-v1-1-5feb20d66a79@chromium.org/T/#u > - platform_get_irq() cannot return 0, fix that (Thanks Dan). > - Fix stb0800 patch. chip_id can be 0 (Thanks Dan). > - Use runtime (IS_ENABLED), code looks nicer. (Thanks Dan). > - Do not replace do_div for venus (Thanks Dan). > - Do not replace do_div for tda10048 (Thanks Dan). > - Link to v1: https://lore.kernel.org/r/20240415-fix-cocci-v1-0-477afb23728b@chromium.org > > --- > Ricardo Ribalda (26): > media: pci: mgb4: Refactor struct resources > media: stb0899: Simplify check > media: uvcvideo: Refactor iterators > media: uvcvideo: Use max() macro > media: go7007: Use min and max macros > media: stm32-dcmipp: Remove redundant printk > media: staging: sun6i-isp: Remove redundant printk > media: dvb-frontends: tda18271c2dd: Remove casting during div > media: v4l: async: refactor v4l2_async_create_ancillary_links > staging: media: tegra-video: Use swap macro > media: s2255: Use refcount_t instead of atomic_t for num_channels > media: platform: mtk-mdp3: Use refcount_t for job_count > media: common: saa7146: Use min macro > media: dvb-frontends: drx39xyj: Use min macro > media: netup_unidvb: Use min macro > media: au0828: Use min macro > media: flexcop-usb: Use min macro > media: gspca: cpia1: Use min macro > media: stk1160: Use min macro > media: tegra-vde: Refactor timeout handling > media: i2c: st-mipid02: Use the correct div function > media: tc358746: Use the correct div_ function > media: venus: vdec: Make explicit the range of us_per_frame > media: venus: venc: Make explicit the range of us_per_frame > media: dvb-frontends: tda10048: Fix integer overflow > media: dvb-frontends: tda10048: Make explicit the range of z. > > drivers/media/common/saa7146/saa7146_hlp.c | 8 +++---- > drivers/media/dvb-frontends/drx39xyj/drxj.c | 9 +++----- > drivers/media/dvb-frontends/stb0899_drv.c | 2 +- > drivers/media/dvb-frontends/tda10048.c | 13 +++++++---- > drivers/media/dvb-frontends/tda18271c2dd.c | 4 ++-- > drivers/media/i2c/st-mipid02.c | 2 +- > drivers/media/i2c/tc358746.c | 3 +-- > drivers/media/pci/mgb4/mgb4_core.c | 4 ++-- > drivers/media/pci/mgb4/mgb4_regs.c | 2 +- > drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +- > .../media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 10 ++++----- > .../media/platform/mediatek/mdp3/mtk-mdp3-core.c | 6 ++--- > .../media/platform/mediatek/mdp3/mtk-mdp3-core.h | 2 +- > .../media/platform/mediatek/mdp3/mtk-mdp3-m2m.c | 6 ++--- > drivers/media/platform/nvidia/tegra-vde/h264.c | 6 ++--- > drivers/media/platform/qcom/venus/vdec.c | 7 ++---- > drivers/media/platform/qcom/venus/venc.c | 7 ++---- > .../platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 7 ++---- > drivers/media/usb/au0828/au0828-video.c | 5 +---- > drivers/media/usb/b2c2/flexcop-usb.c | 5 +---- > drivers/media/usb/go7007/go7007-fw.c | 4 ++-- > drivers/media/usb/gspca/cpia1.c | 6 ++--- > drivers/media/usb/s2255/s2255drv.c | 20 ++++++++--------- > drivers/media/usb/stk1160/stk1160-video.c | 10 ++------- > drivers/media/usb/uvc/uvc_ctrl.c | 26 ++++++++++++---------- > drivers/media/v4l2-core/v4l2-async.c | 7 +++--- > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 3 +-- > drivers/staging/media/tegra-video/tegra20.c | 9 ++------ > 28 files changed, 84 insertions(+), 111 deletions(-) > --- > base-commit: 836e2548524d2dfcb5acaf3be78f203b6b4bde6f > change-id: 20240415-fix-cocci-2df3ef22a6f7 > > Best regards,
Powered by blists - more mailing lists