linux-kernel - [PATCH 1/2] mm: page_owner: fixing wrong information in dump_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240424111838.3782931-1-hariom1.p@samsung.com>
Date: Wed, 24 Apr 2024 16:48:37 +0530
From: Hariom Panthi <hariom1.p@...sung.com>
To: akpm@...ux-foundation.org, urezki@...il.com, hch@...radead.org,
	lstoakes@...il.com, vbabka@...e.cz, osalvador@...e.de
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	r.thapliyal@...sung.com, Maninder Singh <maninder1.s@...sung.com>, Hariom
	Panthi <hariom1.p@...sung.com>
Subject: [PATCH 1/2] mm: page_owner: fixing wrong information in
 dump_page_owner

From: Maninder Singh <maninder1.s@...sung.com>

with commit ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages"),
new API __update_page_owner_handle was introduced and arguemnt was passed
in wrong order from __set_page_owner and thus page_owner is giving
wrong data.

[   15.982420] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid -1210279584 (insmod), ts 80, free_ts 0

Fixing the same.
Correct output:
[   14.556482] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid 80 (insmod), ts 14552004992, free_ts 0

Fixes: ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages")
Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
Signed-off-by: Hariom Panthi <hariom1.p@...sung.com>
---
 mm/page_owner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_owner.c b/mm/page_owner.c
index 742f432e5bf0..6669c7eadfb3 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -328,7 +328,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order,
 	if (unlikely(!page_ext))
 		return;
 	__update_page_owner_handle(page_ext, handle, order, gfp_mask, -1,
-				   current->pid, current->tgid, ts_nsec,
+				   ts_nsec, current->pid, current->tgid,
 				   current->comm);
 	page_ext_put(page_ext);
 	inc_stack_record_count(handle, gfp_mask, 1 << order);
-- 
2.25.1