linux-kernel - Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 14:01:22 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Wren Turkal <wt@...guintechs.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>, 
	Marcel Holtmann <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned
 by gpiod_get_optional()

On Wed, 24 Apr 2024 at 13:59, Wren Turkal <wt@...guintechs.org> wrote:
>
> On 4/24/24 4:53 AM, Bartosz Golaszewski wrote:
> > This must be your email client wrapping lines over a certain limit.
> > Try and get the diff from lore[1], it should be fine.
> >
> > Bart
> >
> > [1]https://lore.kernel.org/lkml/CAMRc=MepDwUbAKrWgm0CXKObqy8=igtug0QDgo-CgwxjZCAC2Q@mail.gmail.com/
>
> I don't think it's my client. The extra newlines are right there in the
> lore link.
>
> Look at the line that starts with "@@". That line is wrapped. The
> following line ("serdev_device *serdev)") should be at the end of the
> previous line. The same thing happened on the second "@@" line as well.
>

Indeed. I just noticed that it applies fine with git apply and figured
the output must be right. Anyway, this is not a proper patch, I will
send one once I adapt Zijun's code.

Bart