linux-kernel - Re: [PATCH 1/2] mm: page_owner: fixing wrong information in dump_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZikALBw17JePpWVh@localhost.localdomain>
Date: Wed, 24 Apr 2024 14:50:52 +0200
From: Oscar Salvador <osalvador@...e.de>
To: Hariom Panthi <hariom1.p@...sung.com>
Cc: akpm@...ux-foundation.org, urezki@...il.com, hch@...radead.org,
	lstoakes@...il.com, vbabka@...e.cz, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, r.thapliyal@...sung.com,
	Maninder Singh <maninder1.s@...sung.com>
Subject: Re: [PATCH 1/2] mm: page_owner: fixing wrong information in
 dump_page_owner

On Wed, Apr 24, 2024 at 04:48:37PM +0530, Hariom Panthi wrote:
> From: Maninder Singh <maninder1.s@...sung.com>
> 
> with commit ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages"),
> new API __update_page_owner_handle was introduced and arguemnt was passed
> in wrong order from __set_page_owner and thus page_owner is giving
> wrong data.
> 
> [   15.982420] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid -1210279584 (insmod), ts 80, free_ts 0
> 
> Fixing the same.
> Correct output:
> [   14.556482] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid 80 (insmod), ts 14552004992, free_ts 0
> 
> Fixes: ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages")
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Signed-off-by: Hariom Panthi <hariom1.p@...sung.com>

Acked-by: Oscar Salvador <osalvador@...e.de>

Thanks!

 

-- 
Oscar Salvador
SUSE Labs