linux-kernel - Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 14:57:56 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Wren Turkal <wt@...guintechs.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>, 
	Marcel Holtmann <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned
 by gpiod_get_optional()

On Wed, 24 Apr 2024 at 14:30, Wren Turkal <wt@...guintechs.org> wrote:
>
> On 4/24/24 5:27 AM, Bartosz Golaszewski wrote:
> > On Wed, Apr 24, 2024 at 2:24 PM Wren Turkal <wt@...guintechs.org> wrote:
> >>>>>
> >>>>> That's OK, we have the first part right. Let's now see if we can reuse
> >>>>> patch 2/2 from Zijun.
> >>>>
> >>>> I'm compiling it right now. Be back soon.
> >>>>
> >>>
> >>> Well I doubt it's correct as it removed Krzysztof's fix which looks
> >>> right. If I were to guess I'd say we need some mix of both.
> >>
> >> Patch 2/2 remove K's fix? I thought only 1/2 did that.
> >>
> >> To be specific, I have applied your patch and Zijun's 2/2 only.
> >>
> >
> > No, patch 1/2 from Zijun reverted my changes. Patch 2/2 removes
> > Krzysztof's changes and replaces them with a different if else. This
> > patch is a better alternative to Zijun's patch 1/2. For 2/2, I'll let
> > Krzysztof handle it.
>
> Got it. Thx.
>
> BTW, should this patch's commit message include the following?
>
> Tested-by: "Wren Turkal" <wt@...guintechs.org>
>

Please respond with this tag under the v2 patch and b4, patchwork or
whatever other tools the maintainer will use will pick it up.

Thanks,
Bartosz

> If so, please feel free to add it.
>
> wt
> --
> You're more amazing than you think!