linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sc7280: Remove CTS/RTS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171396420160.3427004.14810050432348630573.robh@kernel.org>
Date: Wed, 24 Apr 2024 08:14:19 -0500
From: Rob Herring <robh@...nel.org>
To: Viken Dadhaniya <quic_vdadhani@...cinc.com>
Cc: conor+dt@...nel.org, rajpat@...eaurora.org, luca.weiss@...rphone.com, 
 andersson@...nel.org, swboyd@...omium.org, devicetree@...r.kernel.org, 
 cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org, 
 quic_anupkulk@...cinc.com, mka@...omium.org, linux-kernel@...r.kernel.org, 
 konrad.dybcio@...aro.org, quic_msavaliy@...cinc.com, krzk+dt@...nel.org, 
 rojay@...eaurora.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Remove CTS/RTS
 configuration


On Wed, 24 Apr 2024 13:28:53 +0530, Viken Dadhaniya wrote:
> For IDP variant, GPIO 20/21 is used by camera use case and camera
> driver is not able acquire these GPIOs as it is acquired by UART5
> driver as RTS/CTS pin.
> 
> UART5 is designed for debug UART for all the board variants of the
> sc7280 chipset and RTS/CTS configuration is not required for debug
> uart usecase.
> 
> Remove CTS/RTS configuration for UART5 instance and change compatible
> string to debug UART.
> 
> Remove overwriting compatible property from individual target specific
> file as it is not required.
> 
> Fixes: 38cd93f413fd ("arm64: dts: qcom: sc7280: Update QUPv3 UART5 DT node")
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@...cinc.com>
> 
> ---
> v1 -> v2:
> - Remove compatible property from target specific file.
> - Update commit log.
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts |  1 -
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts           |  1 -
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts       |  1 -
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           |  1 -
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi         |  1 -
>  arch/arm64/boot/dts/qcom/sc7280.dtsi               | 14 ++------------
>  6 files changed, 2 insertions(+), 17 deletions(-)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/qcm6490-fairphone-fp5.dtb qcom/qcm6490-idp.dtb qcom/qcs6490-rb3gen2.dtb' for 20240424075853.11445-1-quic_vdadhani@...cinc.com:

arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: usb@...8800: interrupt-names: ['pwr_event', 'hs_phy_irq', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#