linux-kernel - Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 15:18:57 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Wren Turkal <wt@...guintechs.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Marcel Holtmann <marcel@...tmann.org>, 
	Luiz Augusto von Dentz <luiz.dentz@...il.com>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL
 returned by gpiod_get_optional()

On Wed, 24 Apr 2024 at 15:10, Wren Turkal <wt@...guintechs.org> wrote:
>
> On 4/24/24 5:29 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski<bartosz.golaszewski@...aro.org>
> >
> > Any return value from gpiod_get_optional() other than a pointer to a
> > GPIO descriptor or a NULL-pointer is an error and the driver should
> > abort probing. That being said: commit 56d074d26c58 ("Bluetooth: hci_qca:
> > don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets
> > power_ctrl_enabled on NULL-pointer returned by
> > devm_gpiod_get_optional(). Restore this behavior but bail-out on errors.
> > While at it: also bail-out on error returned when trying to get the
> > "swctrl" GPIO.
> >
> > Reported-by: Wren Turkal<wt@...guintechs.org>
> > Reported-by: Zijun Hu<quic_zijuhu@...cinc.com>
> > Closes:https://lore.kernel.org/linux-bluetooth/1713449192-25926-2-git-send-email-quic_zijuhu@quicinc.com/
> > Fixes: 56d074d26c58 ("Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()")
> > Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@...aro.org>
> > Signed-off-by: Bartosz Golaszewski<bartosz.golaszewski@...aro.org>
>
> Tested-by: "Wren Turkal" <wt@...guintechs.org>
>
>
> Like this?

Yes, awesome, thanks.

This is how reviewing works too in the kernel, look at what Krzysztof
did under v1, he just wrote:

Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@...aro.org>

And mailing list tools will pick it up.

Bartosz