linux-kernel - Re: [PATCH] drm/amd/display: re-indent dc_power_down_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3b0e0fe-edb9-420d-b4a1-71c267246875@amd.com>
Date: Wed, 24 Apr 2024 15:33:11 +0200
From: Christian König <christian.koenig@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Harry Wentland <harry.wentland@....com>,
 Charlene Liu <charlene.liu@....com>, Leo Li <sunpeng.li@....com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
 Alex Deucher <alexander.deucher@....com>, "Pan, Xinhui"
 <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Alvin Lee <alvin.lee2@....com>,
 Wenjing Liu <wenjing.liu@....com>, Jun Lei <jun.lei@....com>,
 Tom Chung <chiahsuan.chung@....com>, Dillon Varone <dillon.varone@....com>,
 amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: re-indent dc_power_down_on_boot()

Am 24.04.24 um 15:20 schrieb Dan Carpenter:
> On Wed, Apr 24, 2024 at 03:11:08PM +0200, Christian König wrote:
>> Am 24.04.24 um 13:41 schrieb Dan Carpenter:
>>> These lines are indented too far.  Clean the whitespace.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
>>> ---
>>>    drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++----
>>>    1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> index 8eefba757da4..f64d7229eb6c 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> @@ -5043,11 +5043,10 @@ void dc_interrupt_ack(struct dc *dc, enum dc_irq_source src)
>>>    void dc_power_down_on_boot(struct dc *dc)
>>>    {
>>>    	if (dc->ctx->dce_environment != DCE_ENV_VIRTUAL_HW &&
>>> -			dc->hwss.power_down_on_boot) {
>>> -
>>> -			if (dc->caps.ips_support)
>>> -				dc_exit_ips_for_hw_access(dc);
>>> +	    dc->hwss.power_down_on_boot) {
>>> +		if (dc->caps.ips_support)
>>> +			dc_exit_ips_for_hw_access(dc);
>> Well while at it can't the two ifs be merged here?
>>
>> (I don't know this code to well, but it looks like it).
>>
> I'm sorry, I don't see what you're saying.

The indentation was so messed up that I though the call to 
power_down_on_boot() was after both ifs, but it is still inside the first.

So your patch is actually right, sorry for the noise.

Regards,
Christian.

>
> I probably should have deleted the other blank line as well, though.
> It introduces a checkpatch.pl --strict warning.
>
> regards,
> dan carpenter
>