linux-kernel - Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cec3a862-82a9-4f79-985a-d29816e520c2@kernel.org>
Date: Thu, 25 Apr 2024 20:35:17 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>,
 "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>,
 Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Magnus Damm <magnus.damm@...il.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-mmc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>,
 Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const
 value items into an enum list

On 25/04/2024 19:11, Geert Uytterhoeven wrote:
>>
>>>> +              - renesas,sdhi-sh73a0  # R-Mobile APE6
>>>> +              - renesas,sdhi-r7s72100 # RZ/A1H
>>>> +              - renesas,sdhi-r7s9210 # SH-Mobile AG5
>>>> +              - renesas,sdhi-r8a73a4 # R-Mobile APE6
>>>> +              - renesas,sdhi-r8a7740 # R-Mobile A1
>>>> +              - renesas,sdhi-mmc-r8a77470 # RZ/G1C
>>>
>>> Keep list alphabetically ordered.
>>>
>> This list is sorted based on SoC, I will sort it  alphabetically.
>>
>> Geert is that OK with you?
> 
> Usually we sort alphabetically by compatible value.

BTW, it is also fine if you keep some other sorting rule there, which is
in general known to interested parties. Although I would argue that most
people adding new entries are not aware of such rules, thus they add
things to the end increasing the chances for conflicts.

Best regards,
Krzysztof