linux-kernel - Re: [PATCH v2 21/25] nvdimm: virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <662ac41d1655a_108a3c294c0@iweiny-mobl.notmuch>
Date: Thu, 25 Apr 2024 13:59:09 -0700
From: Ira Weiny <ira.weiny@...el.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "Michael S. Tsirkin"
	<mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Xuan Zhuo
	<xuanzhuo@...ux.alibaba.com>, Jonathan Corbet <corbet@....net>, "David
 Hildenbrand" <david@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>, "Richard
 Weinberger" <richard@....at>, Anton Ivanov <anton.ivanov@...bridgegreys.com>,
	Johannes Berg <johannes@...solutions.net>, Paolo Bonzini
	<pbonzini@...hat.com>, Stefan Hajnoczi <stefanha@...hat.com>, Jens Axboe
	<axboe@...nel.dk>, Marcel Holtmann <marcel@...tmann.org>, "Luiz Augusto von
 Dentz" <luiz.dentz@...il.com>, Olivia Mackall <olivia@...enic.com>, "Herbert
 Xu" <herbert@...dor.apana.org.au>, Amit Shah <amit@...nel.org>, Arnd Bergmann
	<arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Gonglei
	<arei.gonglei@...wei.com>, "David S. Miller" <davem@...emloft.net>, "Sudeep
 Holla" <sudeep.holla@....com>, Cristian Marussi <cristian.marussi@....com>,
	Viresh Kumar <vireshk@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, David Airlie <airlied@...hat.com>,
	Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Daniel Vetter
	<daniel@...ll.ch>, Jean-Philippe Brucker <jean-philippe@...aro.org>, "Joerg
 Roedel" <joro@...tes.org>, Will Deacon <will@...nel.org>, Robin Murphy
	<robin.murphy@....com>, Alexander Graf <graf@...zon.com>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Eric Van Hensbergen <ericvh@...nel.org>, "Latchesar
 Ionkov" <lucho@...kov.net>, Dominique Martinet <asmadeus@...ewreck.org>,
	Christian Schoenebeck <linux_oss@...debyte.com>, Stefano Garzarella
	<sgarzare@...hat.com>, Kalle Valo <kvalo@...nel.org>, Dan Williams
	<dan.j.williams@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, "Dave
 Jiang" <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>, Pankaj Gupta
	<pankaj.gupta.linux@...il.com>, Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>, "James E.J. Bottomley"
	<jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>,
	Vivek Goyal <vgoyal@...hat.com>, Miklos Szeredi <miklos@...redi.hu>, "Anton
 Yakovlev" <anton.yakovlev@...nsynergy.com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>
CC: <virtualization@...ts.linux.dev>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-um@...ts.infradead.org>,
	<linux-block@...r.kernel.org>, <linux-bluetooth@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-gpio@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<iommu@...ts.linux.dev>, <netdev@...r.kernel.org>, <v9fs@...ts.linux.dev>,
	<kvm@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<nvdimm@...ts.linux.dev>, <linux-remoteproc@...r.kernel.org>,
	<linux-scsi@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
	<alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>, "Krzysztof
 Kozlowski" <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 21/25] nvdimm: virtio_pmem: drop owner assignment

Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
> 
> Acked-by: Dave Jiang <dave.jiang@...el.com>

Acked-by: Ira Weiny <ira.weiny@...el.com>

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> 
> Depends on the first patch.
> ---
>  drivers/nvdimm/virtio_pmem.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c
> index 4ceced5cefcf..c9b97aeabf85 100644
> --- a/drivers/nvdimm/virtio_pmem.c
> +++ b/drivers/nvdimm/virtio_pmem.c
> @@ -151,7 +151,6 @@ static struct virtio_driver virtio_pmem_driver = {
>  	.feature_table		= features,
>  	.feature_table_size	= ARRAY_SIZE(features),
>  	.driver.name		= KBUILD_MODNAME,
> -	.driver.owner		= THIS_MODULE,
>  	.id_table		= id_table,
>  	.validate		= virtio_pmem_validate,
>  	.probe			= virtio_pmem_probe,
> 
> -- 
> 2.34.1
>