linux-kernel - Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: ISO C90 forbids mixed declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240425050721.vks2bq7gqwl2gfpe@vireshk-i7>
Date: Thu, 25 Apr 2024 10:37:21 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Portia Stephens <portia.stephens@...onical.com>
Cc: mmayer@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	rafael@...nel.org, florian.fainelli@...adcom.com,
	abelova@...ralinux.ru, linux-pm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	stephensportia@...il.com
Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: ISO C90 forbids mixed
 declarations

On 24-04-24, 15:02, Portia Stephens wrote:
> There is a compile warning because a NULL pointer check was added before
> a struct was declared. This moves the NULL pointer check to after the
> struct is delcared and moves the struct assignment to after the NULL

            declared

> pointer check.
> 
> Fixes: f661017e6d32 ("cpufreq: brcmstb-avs-cpufreq: add check for cpufreq_cpu_get's return value")
> 
> Signed-off-by: Portia Stephens <portia.stephens@...onical.com>
> ---
>  drivers/cpufreq/brcmstb-avs-cpufreq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied. Thanks.

-- 
viresh