linux-kernel - Re: [PATCH 5.15 000/476] 5.15.149-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aceda6e2-cefb-4146-aef8-ff4bafa56e56@roeck-us.net>
Date: Thu, 25 Apr 2024 15:46:18 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org
Cc: patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
 torvalds@...ux-foundation.org, akpm@...ux-foundation.org, shuah@...nel.org,
 patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
 jonathanh@...dia.com, f.fainelli@...il.com, sudipm.mukherjee@...il.com,
 srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
 allen.lkml@...il.com, dianders@...gle.com, briannorris@...gle.com,
 momohatt@...gle.com, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH 5.15 000/476] 5.15.149-rc1 review

Hi,

On 2/21/24 05:00, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.149 release.
> There are 476 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Fri, 23 Feb 2024 12:59:02 +0000.
> Anything received after that time might be too late.
> 
[ ... ]

> Herbert Xu <herbert@...dor.apana.org.au>
>      crypto: api - Disallow identical driver names
> 

This patch results in a severe performance regression on arm64 systems;
there is more than 50% throughput loss on some sequential read tests.
The problem affects v5.15.y and older kernel branches.

Analysis shows that v5.15.y and older kernel _do_ try to register the same
crypto algorithm twice, once through

  __crypto_register_alg
  crypto_register_alg
  crypto_register_skciphers
  aes_init

and then again through

  __crypto_register_alg
  crypto_register_alg
  crypto_register_skcipher
  simd_skcipher_create_compat
  aes_init

After above patch was applied, the second registration fails, resulting
in the regression.

The problem is not seen in later kernels due to commit 676e508122d9
("crypto: arm64/aes-ce - stop using SIMD helper for skciphers"). Applying this
commit or reverting above commit fixes the regression in v5.15.y and older.

Thanks is due to Momoko Hattori for reporting the problem and finding the
offending patch, Doug Anderson for finding the duplicate registration attempt,
and Brian Norris for finding the fix. I copied them on this e-mail in case
there are further questions.

Thanks,
Guenter